give SSOT/SPOT on default field TEST_PATH to avoid DRY#2577
Closed
Pankraz76 wants to merge 1 commit intodiffplug:mainfrom
Closed
give SSOT/SPOT on default field TEST_PATH to avoid DRY#2577Pankraz76 wants to merge 1 commit intodiffplug:mainfrom
SSOT/SPOT on default field TEST_PATH to avoid DRY#2577Pankraz76 wants to merge 1 commit intodiffplug:mainfrom
Conversation
3 tasks
Pankraz76
commented
Jul 24, 2025
plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GroovyExtensionTest.java
Show resolved
Hide resolved
plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GroovyExtensionTest.java
Show resolved
Hide resolved
plugin-gradle/src/test/java/com/diffplug/gradle/spotless/JavaDefaultTargetTest.java
Show resolved
Hide resolved
Pankraz76
changed the title
SPOT on default field TEST_PATH to avoid DRYSSOT/SPOT on default field TEST_PATH to avoid DRY
Author
Member
|
This does not reduce complexity in a meaningful way. It is okay for the string constant to be different in each test, there's no magic to its name. I am not interested in stylistic cleanup PRs. If a PR changes lots of lines, it needs to either
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)